{"id":909,"cve":"CVE-2021-41125","cve_url":"https:\/\/www.cvedetails.com\/cve\/CVE-2021-41125","cwe":"CWE-522","cwe_number":522,"cwe_url":"https:\/\/cwe.mitre.org\/data\/definitions\/522","cvss_score":6.5,"published":"2021-10-06","owasp":"A05 Security Misconfiguration","odc":"Function","cdc":"Incorrect Functionality","category":"Authentication, Authorization, and Session Management","subcategory":"Insecure Authentication Mechanisms","scope":"Remote","impact":"Information Disclosure","summary":"Scrapy exposes HTTP authentication credentials in requests","permalink":"https:\/\/netpack.pt\/vaitp\/vulnerability\/CVE-2021-41125\/","description":"Scrapy is a high-level web crawling and scraping framework for Python. If you use `HttpAuthMiddleware` (i.e. the `http_user` and `http_pass` spider attributes) for HTTP authentication, all requests will expose your credentials to the request target. This includes requests generated by Scrapy components, such as `robots.txt` requests sent by Scrapy when the `ROBOTSTXT_OBEY` setting is set to `True`, or as requests reached through redirects. Upgrade to Scrapy 2.5.1 and use the new `http_auth_domain` spider attribute to control which domains are allowed to receive the configured HTTP authentication credentials. If you are using Scrapy 1.8 or a lower version, and upgrading to Scrapy 2.5.1 is not an option, you may upgrade to Scrapy 1.8.1 instead. If you cannot upgrade, set your HTTP authentication credentials on a per-request basis, using for example the `w3lib.http.basic_auth_header` function to convert your credentials into a value that you can assign to the `Authorization` header of your request, instead of defining your credentials globally using `HttpAuthMiddleware`.","solution":"Upgrade to Scrapy 2.5.1 and use http_auth_domain attribute to control credentials exposure.","affected_component":"Scrapy","fixed_by_upgrading":true,"vulnerable_code":"import scrapy\n\nclass MySpider(scrapy.Spider):\n    name = 'my_spider'\n    http_user = 'your_username'\n    http_pass = 'your_password'\n\n    def start_requests(self):\n        urls = [\n            'http:\/\/example.com',\n            'http:\/\/anotherdomain.com'\n        ]\n        for url in urls:\n            yield scrapy.Request(url)","patched_code":"import scrapy\nfrom w3lib.http import basic_auth_header\n\nclass MySpider(scrapy.Spider):\n    name = 'my_spider'\n    http_user = 'your_username'\n    http_pass = 'your_password'\n    http_auth_domain = ['example.com']\n\n    def start_requests(self):\n        urls = [\n            'http:\/\/example.com',\n            'http:\/\/anotherdomain.com'\n        ]\n        for url in urls:\n            if self.is_auth_domain(url):\n                yield scrapy.Request(url, headers={'Authorization': basic_auth_header(self.http_user, self.http_pass)})\n            else:\n                yield scrapy.Request(url)\n\n    def is_auth_domain(self, url):\n        return any(domain in url for domain in self.http_auth_domain)","payload_needed":false,"payload":null,"payload_status":"none","published_fix":[{"repository":"scrapy\/scrapy","commit_url":"https:\/\/github.com\/scrapy\/scrapy\/commit\/b01d69a1bf48060daec8f751368622352d8b85a6","commit_subject":"Add http_auth_domain to HttpAuthMiddleware.","units":[{"file":"scrapy\/downloadermiddlewares\/httpauth.py","function":null},{"file":"scrapy\/downloadermiddlewares\/httpauth.py","function":"HttpAuthMiddleware.process_request"},{"file":"scrapy\/downloadermiddlewares\/httpauth.py","function":"HttpAuthMiddleware.spider_opened"}]}],"references":null}