{"id":1200,"cve":"CVE-2024-52804","cve_url":"https:\/\/www.cvedetails.com\/cve\/CVE-2024-52804\/","cwe":"CWE-400","cwe_number":400,"cwe_url":"https:\/\/cwe.mitre.org\/data\/definitions\/400","cvss_score":7.5,"published":"2024-11-22","owasp":"A05 Security Misconfiguration","odc":"Algorithm","cdc":"Incorrect Algorithm","category":"Resource Management","subcategory":"Resource Exhaustion","scope":"Remote","impact":"Denial of Service (DoS)","summary":"Tornado's cookie parsing algorithm can lead to excessive CPU usage.","permalink":"https:\/\/netpack.pt\/vaitp\/vulnerability\/CVE-2024-52804\/","description":"Tornado is a Python web framework and asynchronous networking library. The algorithm used for parsing HTTP cookies in Tornado versions prior to 6.4.2 sometimes has quadratic complexity, leading to excessive CPU consumption when parsing maliciously-crafted cookie headers. This parsing occurs in the event loop thread and may block the processing of other requests. Version 6.4.2 fixes the issue.","solution":"Upgrade to Tornado version 6.4.2 or later.","affected_component":"Tornado","fixed_by_upgrading":true,"vulnerable_code":"import tornado.web\nimport tornado.ioloop\n\nclass MainHandler(tornado.web.RequestHandler):\n    def get(self):\n        cookie_header = \"cookie=\" + \"a\" * 1000000\n        self.request.headers['Cookie'] = cookie_header\n        parsed_cookies = self.get_cookies(self.request.headers['Cookie'])\n        self.write(\"Parsed cookies: {}\".format(parsed_cookies))\n\n    def get_cookies(self, cookie_header):\n        cookies = {}\n        for cookie in cookie_header.split(';'):\n            key, value = cookie.split('=', 1)\n            cookies[key.strip()] = value.strip()\n        return cookies\n\ndef make_app():\n    return tornado.web.Application([\n        (r\"\/\", MainHandler),\n    ])\n\nif __name__ == \"__main__\":\n    app = make_app()\n    app.listen(8888)\n    tornado.ioloop.IOLoop.current().start()","patched_code":"import tornado.web\nimport tornado.ioloop\n\nMAX_COOKIE_HEADER_SIZE = 8192\n\nclass MainHandler(tornado.web.RequestHandler):\n    def get(self):\n        cookie_header = \"cookie=\" + \"a\" * 1000\n        if len(cookie_header) > MAX_COOKIE_HEADER_SIZE:\n            self.set_status(400)\n            self.write(\"Cookie header too large.\")\n            return\n\n        try:\n            parsed_cookies = self.get_cookies(cookie_header)\n        except ValueError:\n            self.set_status(400)\n            self.write(\"Malformed cookie.\")\n            return\n\n        self.write(\"Parsed cookies: {}\".format(parsed_cookies))\n\n    def get_cookies(self, cookie_header):\n        cookies = {}\n        for cookie in cookie_header.split(';'):\n            if '=' not in cookie:\n                raise ValueError(\"Malformed cookie\")\n            key, value = cookie.split('=', 1)\n            cookies[key.strip()] = value.strip()\n        return cookies\n\ndef make_app():\n    return tornado.web.Application([\n        (r\"\/\", MainHandler),\n    ])\n\nif __name__ == \"__main__\":\n    app = make_app()\n    app.listen(8888)\n    tornado.ioloop.IOLoop.current().start()\n","payload_needed":true,"payload":"```plaintext\nmalicious_cookie=aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa","payload_status":"available","published_fix":[{"repository":"tornadoweb\/tornado","commit_url":"https:\/\/github.com\/tornadoweb\/tornado\/commit\/d5ba4a1695fbf7c6a3e54313262639b198291533","commit_subject":"httputil: Fix quadratic performance of cookie parsing","units":[{"file":"tornado\/httputil.py","function":null},{"file":"tornado\/httputil.py","function":"_unquote_cookie"}]}],"references":null}