CVE-2022-36070
Poetry on Windows executes untrusted code
- CVSS 7.3
- CWE-426 Untrusted Search Path
- Input Validation and Sanitization
- Local
Poetry is a dependency manager for Python. To handle dependencies that come from a Git repository, Poetry executes various commands, e.g. `git config`. These commands are being executed using the executable’s name and not its absolute path. This can lead to the execution of untrusted code due to the way Windows resolves executable names to paths. Unlike Linux-based operating systems, Windows searches for the executable in the current directory first and looks in the paths that are defined in the `PATH` environment variable afterward. This vulnerability can lead to Arbitrary Code Execution, which would lead to the takeover of the system. If a developer is exploited, the attacker could steal credentials or persist their access. If the exploit happens on a server, the attackers could use their access to attack other internal systems. Since this vulnerability requires a fair amount of user interaction, it is not as dangerous as a remotely exploitable one. However, it still puts developers at risk when dealing with untrusted files in a way they think is safe. The victim could also not protect themself by vetting any Git or Poetry config files that might be present in the directory, because the behavior is undocumented. Versions 1.1.9 and 1.2.0b1 contain patches for this issue.
- CVSS base score
- 7.3
- Published
- 2022-09-07
- OWASP
- A05 Security Misconfiguration
- Orthogonal defect classification
- Function
- Code defect classification
- Incorrect Functionality
- Category
- Input Validation and Sanitization
- Subcategory
- Command Injection
- Accessibility scope
- Local
- Impact
- Arbitrary Code Execution
- Affected component
- Poetry
- Fixed by upgrading
- Yes
Solution
Update Poetry to version 1.1.9 or 1.2.0b1.
Vulnerable code sample
import subprocess
def execute_git_command(command):
# Vulnerable code: using the executable's name instead of its absolute path
try:
result = subprocess.run(['git'] + command, check=True, capture_output=True, text=True)
return result.stdout
except subprocess.CalledProcessError as e:
print(f"Error executing command: {e}")
return None
# Example usage
output = execute_git_command(['config', '--list'])
print(output)Patched code sample
import subprocess
import os
def secure_git_command(command):
# Use the absolute path to the Git executable
git_executable = r"C:\Program Files\Git\bin\git.exe" # Adjust the path as necessary
try:
# Execute the command securely
result = subprocess.run([git_executable] + command, check=True, capture_output=True, text=True)
return result.stdout
except subprocess.CalledProcessError as e:
print(f"Error executing command: {e}")
return None
# Example usage
output = secure_git_command(['config', '--list'])
print(output)Published fix
Public sources link this CVE to the changes below. The code samples above were generated to illustrate the defect; these links lead to the code the project actually changed.
- Ensure the full path to git is used on Windows (python-poetry/poetry-core)
poetry/core/vcs/git.py,poetry/core/vcs/git.py · Git.run,poetry/core/vcs/git.py · GitConfig.__init__
Cite this entry
@misc{vaitp:cve202236070,
title = {{Poetry on Windows executes untrusted code}},
author = {Bogaerts, Fr\'ed\'eric and Ivaki, Naghmeh and Fonseca, Jos\'e},
year = {2022},
note = {VAITP Python Vulnerability Dataset, entry CVE-2022-36070},
howpublished = {\url{https://netpack.pt/vaitp/vulnerability/CVE-2022-36070/}}
}
Introducing the "VAITP dataset": a specialized repository of Python vulnerabilities and patches, meticulously compiled for the use of the security research community. As Python's prominence grows, understanding and addressing potential security vulnerabilities become crucial. Crafted by and for the cybersecurity community, this dataset offers a valuable resource for researchers, analysts, and developers to analyze and mitigate the security risks associated with Python. Through the comprehensive exploration of vulnerabilities and corresponding patches, the VAITP dataset fosters a safer and more resilient Python ecosystem, encouraging collaborative advancements in programming security.
The supreme art of war is to subdue the enemy without fighting.
Sun Tzu – “The Art of War”
:: Shaping the future through research and ingenuity ::
