CVE-2024-21669
Verification of JSON‑LD LDP‑VC proofs ignored, allowing false‑positive presentations.
- CVSS 8.8
- CWE-347 Improper Verification of Cryptographic Signature
- Information Leakage
- Remote
Hyperledger Aries Cloud Agent Python (ACA-Py) is a foundation for building decentralized identity applications and services running in non-mobile environments. When verifying W3C Format Verifiable Credentials using JSON-LD with Linked Data Proofs (LDP-VCs), the result of verifying the presentation `document.proof` was not factored into the final `verified` value (`true`/`false`) on the presentation record. The flaw enables holders of W3C Format Verifiable Credentials using JSON-LD with Linked Data Proofs (LDPs) to present incorrectly constructed proofs, and allows malicious verifiers to save and replay a presentation from such holders as their own. This vulnerability has been present since version 0.7.0 and fixed in version 0.10.5.
- CVSS base score
- 8.8
- Published
- 2024-01-11
- OWASP
- A03 Injection
- Orthogonal defect classification
- Checking
- Code defect classification
- Incorrect Check
- Category
- Information Leakage
- Subcategory
- Insecure Handling of Sensitive Data
- Accessibility scope
- Remote
- Impact
- Unauthorized Access
- Affected component
- Hyperledger Aries Cloud Agent Python
- Fixed by upgrading
- Yes
Solution
Update Hyperledger Aries Cloud Agent Python (ACA-Py) to version 0.10.5 or later
Vulnerable code sample
def verify_presentation(presentation):
proof_verified = verify_proof(presentation['proof'])
presentation_valid = validate_presentation(presentation)
presentation['verified'] = presentation_valid
return presentation['verified']
def verify_proof(proof):
return True
def validate_presentation(presentation):
return TruePatched code sample
def verify_presentation(presentation):
if not isinstance(presentation, dict):
return False
proof = presentation.get('proof')
if not proof or not verify_proof(proof):
return False
if not validate_presentation(presentation):
return False
return True
def verify_proof(proof):
if not isinstance(proof, dict):
return False
return 'signature' in proof and isinstance(proof['signature'], str)
def validate_presentation(presentation):
required_keys = {'id', 'holder', 'proof'}
return required_keys.issubset(presentation.keys())Published fix
Public sources link this CVE to the changes below. The code samples above were generated to illustrate the defect; these links lead to the code the project actually changed.
- fix: report presentation result (hyperledger/aries-cloudagent-python)
aries_cloudagent/vc/vc_ld/verify.py · _verify_presentation - fix: report presentation result (hyperledger/aries-cloudagent-python)
aries_cloudagent/vc/vc_ld/verify.py · _verify_presentation,demo/features/steps/0454-present-proof.py,demo/features/steps/0454-present-proof.py · step_impl#5,demo/features/steps/0454-present-proof.py · step_impl#6
Cite this entry
@misc{vaitp:cve202421669,
title = {{Verification of JSON‑LD LDP‑VC proofs ignored, allowing false‑positive presentations.}},
author = {Bogaerts, Fr\'ed\'eric and Ivaki, Naghmeh and Fonseca, Jos\'e},
year = {2024},
note = {VAITP Python Vulnerability Dataset, entry CVE-2024-21669},
howpublished = {\url{https://netpack.pt/vaitp/vulnerability/CVE-2024-21669/}}
}
Introducing the "VAITP dataset": a specialized repository of Python vulnerabilities and patches, meticulously compiled for the use of the security research community. As Python's prominence grows, understanding and addressing potential security vulnerabilities become crucial. Crafted by and for the cybersecurity community, this dataset offers a valuable resource for researchers, analysts, and developers to analyze and mitigate the security risks associated with Python. Through the comprehensive exploration of vulnerabilities and corresponding patches, the VAITP dataset fosters a safer and more resilient Python ecosystem, encouraging collaborative advancements in programming security.
The supreme art of war is to subdue the enemy without fighting.
Sun Tzu – “The Art of War”
:: Shaping the future through research and ingenuity ::
